Parser errors from within includes should not be rescueable #73722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
jborean93
removed
the
needs_triage
ansibot
added
core_review
mkrizek
commented
Mar 1, 2021
| @@ -470,6 +479,8 @@ def _queue_put(item, *args, **kwargs): | |||
|
|
|||
| mock_inc_file._filename = "test.yml" | |||
| res = strategy_base._load_included_file(included_file=mock_inc_file, iterator=mock_iterator) | |||
| self.assertEqual(len(res), 1) | |||
| self.assertTrue(isinstance(res[0], Block)) | |||
There was a problem hiding this comment.
The code change actually revealed an issue with this unit test.
The mocks caused the parent task to have collections set as a MagicMock instance resulting in debug not being found and _load_included_file throwing AnsibleParserError which was then shadowed by AnsibleError and _load_included_file returned an empty list. The res was not asserted in any way and the test passed.
With this PR AnsibleParserError is thrown instead of being shadowed by AnsibleError, the unit test failed with AnsibleParserError. Now the mocks are "fixed" and the result checked for expected result.
ansibot
added
the
stale_ci
ansibot
added
needs_rebase
ansibot
added
core_review
bcoca
approved these changes
Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #73657
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/strategy/__init__.pylib/ansible/plugins/strategy/free.pylib/ansible/plugins/strategy/linear.py